Add Button component #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Benaiah
force-pushed
the
benaiah/add-svelte-button-component
branch
from
6f2381c to
792d931
Compare
Benaiah
force-pushed
the
benaiah/add-svelte-button-component
branch
from
792d931 to
513c27a
Compare
LouisFettet
reviewed
Apr 26, 2023
Benaiah
force-pushed
the
benaiah/add-svelte-button-component
branch
from
3c24bfd to
053c48c
Compare
- Remove extra specificity of custom styles that collides with USWDS classes - Refactor how "unstyled" prop works to match how it works in the USWDS component library - Make "usa-button--unstyled" class work properly again after custom button styling - Add tests for each variant, both styled and unstyled - Add two unstyled button Storybook stories
hinzed1127
approved these changes
Apr 26, 2023
Comment on lines
+3
to
+18
| $colors: ( | ||
| "primary": #0051ad, | ||
| "primary-dark": #063c7a, | ||
| "primary-darker": #00284d, | ||
| "disabled": #c9c9c9, | ||
| "disabled-dark": #adadad, | ||
| "base-lightest": #f2f1f0, | ||
| "base-light": #a9aeb1, | ||
| "base-dark": #565c65, | ||
| "base-darker": #3d4551, | ||
| "gray-05": #f0f0f0, | ||
| "primary-lightest": #d1e9ff, | ||
| "text-only-hover": rgba(6, 60, 122, 16%), | ||
| "text-only-active": rgba(6, 60, 122, 30%), | ||
| "outline-inverse": #dcdee0, | ||
| ); |
There was a problem hiding this comment.
My site title PR defined the current color palette as global variables. That covers everything here except for the last 3 (and gray-05, although $grayscale-05 is extremely close if that's an acceptable substitution, cc @getpunched )
If we like that approach, I can make a smaller PR to just get that in or do follow-up on this once #50 gets in.
There was a problem hiding this comment.
A follow-up PR to add that would be great! I've added a TODO comment indicating that we should do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: LDAF-176
Proposed changes
Buttoncomponent with variants based on the LDAF design system.Screenshots
Acceptance criteria validation